Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all forms to formview declarations [WEB-2984] #663

Merged
merged 32 commits into from
Jan 29, 2025
Merged

Update all forms to formview declarations [WEB-2984] #663

merged 32 commits into from
Jan 29, 2025

Conversation

nikhiltri
Copy link
Member

No description provided.

@nikhiltri nikhiltri force-pushed the feature/twill-update-forms-formview branch 4 times, most recently from 1d9a740 to 6d22b6f Compare January 25, 2025 03:10
@nikhiltri nikhiltri marked this pull request as ready for review January 27, 2025 16:30
zachgarwood
zachgarwood requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into an issue on the Exhibition edit page locally

resources/views/twill/exhibitions/form.blade.php Show resolved Hide resolved
@nikhiltri nikhiltri requested a review from zachgarwood January 27, 2025 20:37
zachgarwood
zachgarwood approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nikhiltri
Update articles form to use form view method [WEB-2984]
b1303d0
@nikhiltri
Build out HomeFeatures to test out formview's connected fields [WEB-2984
04f1cea 
]
@nikhiltri
Update form input declarations to formview [WEB-2984]
d22739c
@nikhiltri
Update WYSIWYG declarations to formview [WEB-2984]
ba11b65
@nikhiltri
Update checkbox declarations to formview [WEB-2984]
047460c
@nikhiltri
Update radio button declarations to formview [WEB-2984]
e721fec
@nikhiltri
Update select field declarations to formview [WEB-2984]
f969e28
@nikhiltri
Update multi-select field declarations to formview [WEB-2984]
332647d
@nikhiltri
Update date-picker field declarations to formview [WEB-2984]
bafc2dd
@nikhiltri
Update medias field declarations to formview [WEB-2984]
54bd227
@nikhiltri
Lint input field [WEB-2984]
0500f4e
@nikhiltri
Update files field declarations to formview [WEB-2984]
bec73e0
@nikhiltri
Update browser field declarations to formview [WEB-2984]
915f245
@nikhiltri
Update repeater field declarations to formview [WEB-2984]
7a55973
@nikhiltri
Update block-editor field declarations to formview [WEB-2984]
321b2da
@nikhiltri
Update color field declarations to formview [WEB-2984]
5411fcb
@nikhiltri
Update formConnectedFields declarations to formview [WEB-2984]
4622c57
@nikhiltri
Lint formview syntax [WEB-2984]
830b2a1
@nikhiltri
Update formFieldset declarations to formview [WEB-2984]
eb3df72
@nikhiltri
Lint code [WEB-2984]
a96c0e9
@nikhiltri
Update browser routes and pass filter parameters to browsers [WEB-2984]
223c4b6
@nikhiltri nikhiltri force-pushed the feature/twill-update-forms-formview branch from 9d3ea29 to 85c302c Compare January 29, 2025 18:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nikhiltri nikhiltri merged commit 40ff015 into feature/twill-upgrade Jan 29, 2025
4 checks passed
@nikhiltri nikhiltri deleted the feature/twill-update-forms-formview branch January 29, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgarwood zachgarwood zachgarwood approved these changes

Assignees

@nikhiltri nikhiltri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhiltri @zachgarwood